From 3e91b99b68c6fe2a39b407e755a795ae280d1948 Mon Sep 17 00:00:00 2001
From: t0chk <86585817+t0chk@users.noreply.github.com>
Date: Sat, 2 Dec 2023 10:45:56 +0300
Subject: [PATCH] revert to pagination and add js-doc to futures

---
 src/spot-client.ts                |  8 ++------
 src/types/request/v1/futuresV1.ts | 10 ++++++++++
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/spot-client.ts b/src/spot-client.ts
index 2fd8331..975e976 100644
--- a/src/spot-client.ts
+++ b/src/spot-client.ts
@@ -112,16 +112,12 @@ export class SpotClient extends BaseRestClient {
   getCandles(
     symbol: string,
     period: SpotKlineInterval,
-    limit?: string,
-    after?: string,
-    before?: string,
+    pagination?: Pagination, 
   ): Promise<APIResponse<SpotCandleData[]>> {
     return this.get('/api/spot/v1/market/candles', {
       symbol,
       period,
-      limit,
-      after,
-      before
+      ...pagination,
     });
   }
 
diff --git a/src/types/request/v1/futuresV1.ts b/src/types/request/v1/futuresV1.ts
index 2d6a8aa..527e967 100644
--- a/src/types/request/v1/futuresV1.ts
+++ b/src/types/request/v1/futuresV1.ts
@@ -216,4 +216,14 @@ export interface HistoricPlanOrderTPSLRequest {
   isPlan?: string;
 }
 
+/**
+ * @typedef  {string[6]} FuturesCandleData
+ * @property {Array[0]} Timestamp in milliseconds
+ * @property {Array[1]} Opening price
+ * @property {Array[2]} Highest price
+ * @property {Array[3]} Lowest price
+ * @property {Array[4]} Closing price - Value of the latest candle stick might change
+ * @property {Array[5]} Base currency trading volume
+ * @property {Array[6]} Quote currency trading volume
+ */
 export type FuturesCandleData = string[6];
\ No newline at end of file