From 470415056eb439c023a8cdb058bc498bf1991734 Mon Sep 17 00:00:00 2001 From: Stefan Aebischer Date: Mon, 20 Jan 2020 22:18:29 -0500 Subject: [PATCH] Fix getPosition * Re adds the v1 endpoint as `getPositions` * Fixes params for v2 endpoint `getPosition` Resolves: #5 --- doc/rest-client.md | 6 +++++- lib/rest-client.js | 11 +++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/doc/rest-client.md b/doc/rest-client.md index 4158350..a4c27ac 100644 --- a/doc/rest-client.md +++ b/doc/rest-client.md @@ -52,9 +52,13 @@ If you only use the [public endpoints](#public-endpoints) you can ommit key and #### async changeUserLeverage(params) [See bybit documentation](https://github.com/bybit-exchange/bybit-official-api-docs/blob/master/en/rest_api.md#-change-user-leverage) -#### async getPosition() +#### async getPosition(params) [See bybit documentation](https://github.com/bybit-exchange/bybit-official-api-docs/blob/master/en/rest_api.md#-my-position-v2) +#### async getPositions() +*Deprecated v1 method* +[See bybit documentation](https://github.com/bybit-exchange/bybit-official-api-docs/blob/master/en/rest_api.md#positionlistget) + #### async changePositionMargin(params) [See bybit documentation](https://github.com/bybit-exchange/bybit-official-api-docs/blob/master/en/rest_api.md#-change-position-margin) diff --git a/lib/rest-client.js b/lib/rest-client.js index b58e729..121f3e6 100644 --- a/lib/rest-client.js +++ b/lib/rest-client.js @@ -109,8 +109,15 @@ module.exports = class RestClient { return await this.request.post('/user/leverage/save', params); } - async getPosition() { - return await this.request.get('/v2/private/position/list'); + async getPosition(params) { + assert(params, 'No params passed'); + assert(params.symbol, 'Parameter symbol is required'); + + return await this.request.get('/v2/private/position/list', params); + } + + async getPositions() { + return await this.request.get('/position/list'); } async changePositionMargin(params) {