From 1d80ed6cbf95ce6e0215fc5ae7314ad61803d0cd Mon Sep 17 00:00:00 2001 From: Justinas Mankus Date: Thu, 17 Nov 2022 18:25:22 +0200 Subject: [PATCH 1/3] param types for HistoryTradeRecords request --- src/linear-client.ts | 3 ++- src/types/request/linear.ts | 11 +++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/linear-client.ts b/src/linear-client.ts index 48b1ab5..724601c 100644 --- a/src/linear-client.ts +++ b/src/linear-client.ts @@ -9,6 +9,7 @@ import { LinearConditionalOrderRequest, LinearGetClosedPnlRequest, LinearGetConditionalOrderRequest, + LinearGetHistoryTradeRecordsRequest, LinearGetOrderRequest, LinearGetOrdersRequest, LinearGetTradeRecordsRequest, @@ -341,7 +342,7 @@ export class LinearClient extends BaseRestClient { } getHistoryTradeRecords( - params: LinearGetTradeRecordsRequest + params: LinearGetHistoryTradeRecordsRequest ): Promise> { return this.getPrivate('/private/linear/trade/execution/history-list', params); } diff --git a/src/types/request/linear.ts b/src/types/request/linear.ts index 6901a24..eaafcb6 100644 --- a/src/types/request/linear.ts +++ b/src/types/request/linear.ts @@ -172,6 +172,17 @@ export interface LinearGetTradeRecordsRequest { exec_type?: string; page?: number; limit?: number; + page_token?: string; +} + +export interface LinearGetHistoryTradeRecordsRequest { + symbol: string; + start_time?: number; + end_time?: number; + exec_type?: string; + page?: number; + limit?: number; + page_token?: string; } export interface LinearGetClosedPnlRequest { From 7118af881436d7bafce65ea740f4de2e8f6d9fec Mon Sep 17 00:00:00 2001 From: Justinas Mankus Date: Thu, 17 Nov 2022 18:25:55 +0200 Subject: [PATCH 2/3] add fix --- src/types/request/linear.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/types/request/linear.ts b/src/types/request/linear.ts index eaafcb6..6fb1f4f 100644 --- a/src/types/request/linear.ts +++ b/src/types/request/linear.ts @@ -172,7 +172,6 @@ export interface LinearGetTradeRecordsRequest { exec_type?: string; page?: number; limit?: number; - page_token?: string; } export interface LinearGetHistoryTradeRecordsRequest { From 6b17fbe5bae715b3aa046bb2a3c1db03219f6ef0 Mon Sep 17 00:00:00 2001 From: Justinas Mankus Date: Thu, 17 Nov 2022 18:29:07 +0200 Subject: [PATCH 3/3] bumping version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 87916b0..4405c8b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "bybit-api", - "version": "3.3.1", + "version": "3.3.3", "description": "Complete & robust node.js SDK for Bybit's REST APIs and WebSockets, with TypeScript & integration tests.", "main": "lib/index.js", "types": "lib/index.d.ts",